Feedback for A1 part a ---------------------- 1) Many of you have written code or have a design that compares pairs of files. Remember that for part b you will need to use cosequential processing instead. 2) There is no reason to use seekp() for this assignment - you are never writing to a file. Some of you are calling seekp() immediately after each call to seekg(). This is unnecessary. The read and write pointers are completely independent of each other. 3) Whenever you use dynamic allocation of memory, you should check to see if the memory allocation was successful: e.g. char* a = new char[10]; if (!a) { // Print an error message and stop the program. } 4) Avoid magic numbers and use constants instead. You can either use #define or you can declare const variables in your classes. 5) Some of you have written code that tests if a char read from a file has a negative value. Instead of doing this, you should always use an unsigned char when reading bytes from a file. Some compilers will require a cast in order for this to work: e.g. unsigned char b; fs.read((char *) &b, sizeof(char)); 6) If you want to pass an fstream object to a method, you must use either a pointer or a reference. This method declaration will *not* work: int myMethod(fstream fs}; These method declarations do work: // Using a pointer to the fstream object. int myMethod(fstream* fs); // Using a reference. int myMethod(fstream& fs); --Ali