[11:04] Nick change: bwinton_away -> bwinton
[11:14] Nick change: bwinton -> bwinton_away
[12:44] Nick change: bwinton_away -> bwinton
[14:22] robertb_frantil (~rburke@129-97-184-162.uwaterloo.ca) joined #markus.
[14:39] robertb_frantil (~rburke@129-97-184-162.uwaterloo.ca) left irc: Quit: robertb_frantil
[14:42] robertb_frantil (~rburke@129-97-184-162.uwaterloo.ca) joined #markus.
[14:43] jmate (~jmate@129-97-248-23.uwaterloo.ca) joined #markus.
[15:04] brianxu (~bxa3@125.127.150.219) joined #markus.
[15:07] m_conley (~m_conley@red-gw35.cs.toronto.edu) joined #markus.
[15:07] <m_conley> Hello, all
[15:08] <brianxu> hi
[15:09] <jmate> hello
[15:09] <m_conley> brianxu: Good news - your patch to remove marks has caught a few eyes here in our department - they want me to prepare a patch with it for 0.6 so they can use it right away. :)
[15:11] <brianxu> remove marks?
[15:11] <m_conley> Yep
[15:11] <brianxu> oops, u mean the reset mark?
[15:11] <m_conley> Yep. :)
[15:11] <brianxu> cool, i just commited it
[15:12] <m_conley> Saw that - nice work
[15:12] <brianxu> how about the flexible scheme,=P, did u get chance to try it?
[15:12] <m_conley> I'm demoing it for Karen today
[15:13] <m_conley> I have a couple of suggestions for the code, but I'm still writing up my review
[15:13] <m_conley> Sorry for the delay - other courses, etc. :p
[15:13] <brianxu> thats fine, =)
[15:16] brianxu1 (~Brian@125.127.150.219) joined #markus.
[15:16] brianxu (bxa3@125.127.150.219) left #markus.
[15:19] bryanshen (~bryanshen@218.74.195.168) joined #markus.
[15:29] reid (~reid@red-gw33.cs.toronto.edu) joined #markus.
[15:30] <reid> Hi everyone!
[15:30] <bryanshen> hello
[15:30] <m_conley> Hey!
[15:30] <brianxu1> hi!
[15:30] <reid> I think that might be everyone. Farah is busy with grad visit day
[15:30] <m_conley> I think we're only missing Farah.
[15:30] <m_conley> Ok.
[15:31] <reid> So, one reminder: Please remember to write your midterm review for the UCOSP blog.
[15:31] <reid> I think Robert and Farah have done theirs.
[15:32] <robertb_frantil> alo
[15:32] <reid> Let's see where everyone is at.
[15:32] <reid> brianxu1 do you want to go first?
[15:32] <brianxu1> sure
[15:33] <brianxu1> for last week, i have been working on the flexible scheme most of my time
[15:33] <brianxu1> the prototype is created
[15:34] <brianxu1> and now we can use both flexible scheme and rubric scheme
[15:34] <reid> Cool!
[15:34] <m_conley> reid: I have a demo ready when you'd like to try it.
[15:34] <brianxu1> and i closed the ticket for reseting mark:-D
[15:34] <reid> m_conley: anytime
[15:35] <reid> brianxu1: thanks for that ticket. I think we will role it into production this week because it is a frequently requested feature.
[15:35] <m_conley> reid: Alright - how about after the status updates?
[15:35] <reid> m_conley sounds good I was wondering how far behind I was on the state of the prototype
[15:36] <reid> What is next for the flexible scheme?
[15:36] <brianxu1> as i suggest on the review board, i will need to provide warning info for switching scheme
[15:37] <brianxu1> and aslo disconnect old records after switching scheme
[15:37] <brianxu1> bryan is working on test with me
[15:38] <brianxu1> i believe we will have tests done when we finish all the required function
[15:38] <reid> great! How much work do you think is left to do? How many weeks?
[15:38] <brianxu1> within 1 or 2 week
[15:39] <m_conley> I'd like to mention that I haven't finished my initial review yet, but that I do have one major concern with the code
[15:39] <reid> excellent. So then we need to find a bit more work for you to do this term (in a couple of weeks)
[15:39] <m_conley> there are a lot of "if using rubric, do this...else assume flexible" scattered throughout. This goes a bit against the point of OOP - I'll be working with Brian/Bryan to find a neater solution
[15:39] <reid> okay thanks
[15:39] <brianxu1> yep, bryan already suggested me how to slove it
[15:40] <m_conley> Oh. Excellent. :)
[15:40] <reid> bryanshen: your turn I think. You have been working on tests and...
[15:40] <brianxu1> when i was doing the prototype, i tried my best to keep the previous codes, so that i didn't destroy them
[15:40] <bryanshen> yes.
[15:41] <bryanshen> I have done some manual tests and gave Brian my feedbacks.
[15:41] <bryanshen> Now I'm focusing on the functional tests.
[15:41] <reid> Is there enough work on the testing to keep you busy for a week or two?
[15:42] <bryanshen> I don't think so.
[15:42] <bryanshen> Most tests are already there.
[15:42] <bryanshen> because Brian didn't modify the controllers and the models too much.
[15:43] <bryanshen> The existing functional tests and unit tests have some decent coverage
[15:43] <bryanshen> All I need to do is to add some extra tests or test data.
[15:43] <reid> Okay, did we already talk about working on something else?
[15:44] <reid> I can't remember if it was jmate or you that we were talking about tackling the problem of assigning Tas to rubric elements
[15:44] <m_conley> It was jmate
[15:44] <jmate> that was me
[15:44] <reid> thanks.
[15:44] <jmate> if have not started looking to it
[15:44] <reid> :-( (With the midterms, I'm really behind this week)
[15:45] <reid> okay, so we need another reasonable piece for bryanshen to work on. (with 5 weeks to go)
[15:45] <bryanshen> sure
[15:45] <bryanshen> Assigning TAs to rubric?
[15:46] <m_conley> I believe that's closely related to jmate's task - though perhaps you could share...
[15:46] <reid> I think jmate was going to work on that one.
[15:46] <reid> m_conley: how about the detailed view in the paginated submissions view?
[15:47] <m_conley> That's also semi-related to something jmate is working on - jmate was looking at ways of getting the submissions table to work/sort without AJAX for bookmarks/back-button
[15:47] <reid> right.
[15:48] <jmate> reid, m_conley, bryanshen: maybe I can swap out that task with the detailed view in the paginated submissions view?
[15:48] <jmate> that way we are not trampling eachothers' feet
[15:48] <reid> since you are already in that code that would make sense.
[15:48] <m_conley> That makes sense.
[15:49] <m_conley> So, jmate will work on de-AJAXifying Submissions Table, putting Detailed Table back
[15:49] <m_conley> bryanshen will work assigning TAs to rubric?
[15:49] <bryanshen> ok
[15:50] <reid> So, the idea with assigning TAs to rubric elements is that we want to be able to associate a TA with the rubric elements they are responsble for so that we can make those elements more visible in the grader view.
[15:50] <bryanshen> I see.
[15:50] <reid> bryanshen, we will probably need to talk offline about the intent
[15:50] <m_conley> This might also somewhat bump up against what Fernando has been doing, styling the rubric
[15:50] <reid> That's okay.
[15:51] <bryanshen> reid, sure
[15:51] <reid> The biggest aspect right now is to get the object models to support this in place. We can worry about exactly how to do the styling later.
[15:52] <m_conley> bryanshen: Have you been keeping up with Victoria's designs for the new interface?
[15:52] <bryanshen> m_conley, not yet.
[15:52] <m_conley> Because this new task is somewhat related...not sure where it fits in.
[15:52] <reid> The views definitely interact with that
[15:52] <reid> stuff
[15:53] <m_conley> When you get a chance, check out her prototypes, and maybe chat with her to get ideas
[15:53] <m_conley> on how to approach this, UI-wise
[15:53] <bryanshen> m_conley: yes. sure
[15:53] <reid> I should write up a brief doc to describe what we want. bryanshen, you will probably need to bug me for this.
[15:54] <bryanshen> reid: I will.
[15:54] <reid> jmate: anything to add on your stuff? I liked the blog article!
[15:54] <m_conley> Me too!
[15:54] <reid> (articles)
[15:55] <jmate> Severin figured out a much better way to update the URL so I am happy that I posted my ideas.
[15:55] <jmate> i am also using Severin's idea for fixing the nested form problem
[15:55] <jmate> the drop down lists can redirect without being tested inside a <form>
[15:56] <jmate> i just wanted to make sure that it's not too big of a hack
[15:57] <m_conley> I don't think it will be
[15:57] <jmate> awesome
[15:57] <jmate> what about verifying that my changes did not break any of the functionality?
[15:58] <jmate> do have selenium tests on the page?
[15:58] <m_conley> That's a bit trickier, seeing as how we don't have any selenium tests for it
[15:58] <m_conley> nope. :/
[15:58] <jmate> ah darn
[15:58] <m_conley> Yep, our selenium tests are really lacking.
[15:58] <m_conley> We're doing a great job with unit/functionals though.
[15:58] <jmate> since nothing was moved on the page, it would have been nice to have some confidence that my stuff didn't break anything from the regression tests
[15:59] <m_conley> We'll give it some good ol' fashion manual testing - maybe write those selenium tests while we're at it.
[15:59] <jmate> alright cool
[16:00] <jmate> do you mind if I talk to you later on about how to test it manually? I want to make sure I cover all the things a user can do
[16:00] <m_conley> Sure.
[16:00] <jmate> i'll fire an email off and a review when I think I'm done the coding
[16:00] <m_conley> Sounds good.
[16:00] <jmate> i think that's it
[16:01] <reid> excellent
[16:01] <reid> robertb_frantil?
[16:02] <robertb_frantil> midterms did a number on my schedule this week, as converting tests from non-shoulda to shoulda is quite slow going
[16:02] <robertb_frantil> I'm going to finish off doing the Student Tests to shoulda while I'm busy travelling, but then I think I should focus on the notables, I can move to converting tests afterwards
[16:03] <reid> that makes sense
[16:03] <reid> Anything else we need to discuss?
[16:04] <m_conley> I can't think of anything.
[16:04] <robertb_frantil> alas, no. I just feel bad for not getting as much done as I would like.
[16:04] <bryanshen> m_conley, I'm wondering how to test the views.
[16:05] <m_conley> bryanshen: Alright, sure, we can talk about that
[16:05] <m_conley> But first
[16:06] <reid> okay I'm checking
[16:06] <reid> I think we are done with the formal meeting. Thanks everyone.
[16:06] <m_conley> bryanshen: Which view/functions did you want to test?
[16:07] <reid> This is where it gets a bit hard to stay motivated and focussed. Next week I'll ask for a plan for the rest of the term. If you need more info from me to do that, let me know.
[16:07] <bryanshen> Now I'm focusing on the Results controller and the related views
[16:07] <m_conley> This is for the FlexibleCriteria tests?
[16:07] <bryanshen> yes.
[16:07] <m_conley> Ok.
[16:08] <m_conley> Testing views is a bit tricky. Have you tried using Selenium yet?
[16:08] <bryanshen> I couldn't make it work
[16:08] <m_conley> Ok, because that's really the only good way I know to test Views
[16:09] <bryanshen> But in functional tests, we can assert to have some html elements in a view, right?
[16:09] <m_conley> And even then, my experience with it is a bit shoddy
[16:09] <m_conley> We can, yes
[16:09] <m_conley> But that only goes so far. Can't simulate clicks
[16:09] <m_conley> ,etc
[16:09] <bryanshen> I see.
[16:09] <m_conley> You can assert the presence of elements, but that's about how far it goes.
[16:10] <bryanshen> Well, actually I'm more concerned about ensuring every view works well (not throwing exceptions)
[16:11] <m_conley> Ah - that can be done in Functional tests
[16:11] <bryanshen> yes, true.
[16:11] <m_conley> Let me see if I can find you an example - hang on...
[16:11] robertb_frantil (rburke@129-97-184-162.uwaterloo.ca) left #markus.
[16:12] <m_conley> bryanshen: See: https://stanley.cdf.toronto.edu/drproject/csc49x/olm_rails/browser/trunk/test/functional?file=groups_controller_test.rb#L108
[16:12] <m_conley> This test pulls the page, and just ensures that the page rendered with a 200 code.
[16:12] <m_conley> (Which wouldn't be the case if an exception was caught)
[16:12] <bryanshen> I see.
[16:14] <bryanshen> If I'm adding some test cases, should I use machinist or stick to fixtures?
[16:14] <m_conley> Well
[16:14] brianxu1 (~Brian@125.127.150.219) left irc: Read error: Connection reset by peer
[16:15] <m_conley> brb
[16:15] brianxu (~Brian@125.127.150.219) joined #markus.
[16:15] <bryanshen> sure
[16:19] <bryanshen> m_conley: I'm going to have some sleep. talk to you later.
[16:19] bryanshen (~bryanshen@218.74.195.168) left irc: Quit: Leaving
[16:20] jmate (~jmate@129-97-248-23.uwaterloo.ca) left irc: Quit: Leaving
[16:21] brianxu (~Brian@125.127.150.219) left irc: Read error: Connection reset by peer
[16:22] <reid> m_conley: I've been playing with the demo
[16:22] <m_conley> What do you think?
[16:22] <reid> There are still a few bits of functionality missing, but I like the overall look.
[16:22] <m_conley> Ok
[16:23] brianxu (~Brian@125.127.150.219) joined #markus.
[16:23] <m_conley> Which bits of functionality?
[16:23] <reid> Some of the saving of values doeesn't quite work yet,
[16:23] <reid> but the overall design looks great.
[16:23] <brianxu> which one?
[16:23] <reid> when I enter values into the rubric they don't appear in the summary
[16:24] <brianxu> u mean when u r using rubric the summary doesnt show the values?
[16:25] <reid> yes
[16:25] <brianxu> i believe it is because the change to the type of mark